-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(run): better handling of ghost linux user during ghost run #327
Conversation
also cc @ErisDS for the wording of the error messages |
d2fd651
to
efc1df9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, not tested on a server yet.
tested and verified that this works 👍 |
Meep. I have no context. What's going on here?
|
^ makes no sense to me because ghost cli sets up a "ghost" system user. |
Sorry, more context. Because ghost-cli sets up the "ghost" system user, running Updating it to be more clear. |
efc1df9
to
d85fce3
Compare
@ErisDS wording is a bit better now (I think) |
Does "initially" mean "the first time it is run"? I'm also confused as to why this closes #307 @sebgie Please intervene here. I don't understand how what's happening in this PR relates to your permissions guide:
It is so hard right now to keep track of the context of why a decision was made. IMO this issue should be referencing a spec. |
It closes #307 because this is kind of a two-fix PR - the first part (the one that closes #307) I will split out into a separate PR to not be as confusing. First part = saving the content path to the config file instead of mutating process.env This is related to both #303 and #311 - an actual write up of the spec for this change is in this comment initially = every time, since |
refs TryGhost#311 - add handling to linux extension that ensures the user is correct
d85fce3
to
7d107d8
Compare
I agree with Hannah, given that all ghost-cli commands are run without From Slack: https://ghost.slack.com/archives/C1QUCB9T9/p1499681674116302
Is there a way to let the CLI ask for sudo if needed? I see that run.js uses |
We could, but that would require hardcoding of the Linux extension's behavior into Ghost-CLI itself. I'm willing to do that, but I think that implication does need to be considered. |
We are going to make the ghost system user mandatory for Linux systems (#334). To resolve the |
Closing this as per #334 |
refs #311